Skip to content

Informative msgs when JsonPatchException is thrown #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Informative msgs when JsonPatchException is thrown #103

wants to merge 2 commits into from

Conversation

objectsmiths
Copy link

  1. This PR adds informative msgs to the cases when JsonPatchException is thrown . (for example a missing path is passed etc.).
  2. All the tests have been modified to take in to account the new messages.
  3. We have used this software in our internal project and found it useful to have this information when some thing changed on our backend and the front end was in sync. It would throw generic jsonPatchException (with noSuchPath or noSuchParent which while useful would not pin point to the location of the error. This becomes a problem in projects with quite a few team members who are not proficient in debugging and the architecture is complex.
  4. All the tests are passing after the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@objectsmiths @ramnukalacbre